gh-144048: Use flexible array members #144049
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all cases can be converted because some structs with this are members in the middle of bigger structs, so changing them introduces warnings. Leave them alone for now.
AZero13
requested review from
ZeroIntensity and
ericsnowcurrently
as code owners
Member
|
As I mentioned on the issue this isn't worth the change IMO. |
vstinner
reviewed
Jan 20, 2026
| size_t size; | ||
| size_t top; | ||
| PyObject * data[1]; /* Variable sized */ | ||
| PyObject * data[]; |
Member
There was a problem hiding this comment.
Please avoid flexible array in the public C API (_PyStackChunk in Include/cpython/pystate.h): revert this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all cases can be converted because some structs with this are members in the middle of bigger structs, so changing them introduces warnings. Leave them alone for now.