Skip to content

Conversation

@davidscn
Copy link
Member

@davidscn davidscn commented Jan 22, 2026

The open question is a bit how to handle the MercuryDPM participant, as the coupled code is entirely compiled with MerucryDPM

https://bitbucket.org/mercurydpm/mercurydpm/pull-requests/266

In principle, using

make ChannelTransport

and copying the executable compiled in ./build/./Drivers/PreCICE/ChannelTransport is sufficient. Afterwards simply execute the case.

image

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@MakisH MakisH self-requested a review January 26, 2026 17:05
@MakisH
Copy link
Member

MakisH commented Jan 26, 2026

The README.md file is currently missing.

We need to rethink how we are distributing solver codes that are built directly in the build tree of the respective solver. A good place to document this then would be the adapter software engineering page.


Particle participant:

* MercuryDPM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More information needed here (I know you know, just for the overview).

Comment on lines +20 to +21
![preCICE configuration visualization](images/tutorials-channel-transport-precice-config.png
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![preCICE configuration visualization](images/tutorials-channel-transport-precice-config.png
)
![preCICE configuration visualization](images/tutorials-channel-transport-precice-config.png)

and image missing

Comment on lines +12 to +15
## Setup

We model a two-dimensional incompressible fluid flowing through a channel with an obstacle. The fluid problem is coupled to a particle participant for particle tracing. Similar to the transport problem (see the [channel-transport tutorial](tutorials-channel-transport.html)), particles are arranged in a circular blob close to the inflow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add here the very nice picture from the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants