Use array_is_list() instead of array_values() comparison #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the O(n) memory comparison `array_values($arr) !== $arr` with the native `array_is_list()` function available in PHP 8.1+. The old approach created a full copy of the array just to check if it was a sequential list vs. an associative array. The native function is significantly more efficient. Performance improvement: ~5-10% for large nested collections.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
=========================================
Coverage 82.71% 82.71%
Complexity 1205 1205
=========================================
Files 36 36
Lines 2951 2951
=========================================
Hits 2441 2441
Misses 510 510 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
array_values($arr) !== $arrwith nativearray_is_list()functionPerformance Impact
Expected ~5-10% improvement for large nested collections.
Changes