-
Notifications
You must be signed in to change notification settings - Fork 21
Read only disks #3021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ipv6_migration
Are you sure you want to change the base?
Read only disks #3021
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
app/components/StateBadge.tsx
Outdated
|
|
||
| export const ReadOnlyBadge = () => ( | ||
| <Badge color="neutral" className="relative"> | ||
| read only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a silly nit, but I feel like even if it's made uppercase its good practice to case them properly
| <SnapshotSelectField control={control} /> | ||
| <div className="mt-2"> | ||
| <CheckboxField name="diskBackend.diskSource.readOnly" control={control}> | ||
| Make disk read-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Make disk" is strange? Maybe just "Read-only"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put that in there tentatively because when it was just read-only, it wasn't clear enough that read-only refers to the resulting disk. So I think we need something more than read-only. Unless we just make the label "Read only" and we put help text in there that says "Instances won't be able to write to this disk" or something. I am also slightly torn about the hyphen. Generally I feel like hyphen is right for regular copy, but when it's just "Read-only" by itself it looks bad.
|
Are there consequences to this action we want to communicate after the user has checked the box? Do we need to clarify that it cannot edited later? |
|
Scattergun thoughts contd:
|
|
|
Further update on cloud-init: because cloud-init is fundamentally a program that runs in the guest OS and pulls data from the CIDATA volume, they just have to not do that (chat). |
I'd like to add some stuff to the docs about read-only disks, perhaps the checkbox should have a link to there?
As of oxidecomputer/omicron@4c3bd6b, it should also be an option for |
Threw this together real quick to de-risk and get a sense of the vibes. API built from oxidecomputer/omicron#9731, which isn't merged yet and we're not sure if it will make it in for v18. This is built on top of #3005 because that has earlier API changes in it.
Fun questions
Read only: Yesin the side modal looks silly, also not as grouped together with snapshot ID as I would like.