-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix(shell): pass literal pattern when glob matches no files #26318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
When a glob pattern doesn't match any files, pass the literal pattern to the command instead of erroring with "no matches found". This matches bash's default behavior (vs zsh's failglob). Fixes #26317 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
WalkthroughGlob expansion behavior when patterns match no files is modified. Previously, the system would error on zero matches; now it consistently passes the literal pattern through. The implementation, existing tests, and regression test are updated to reflect this behavior change. Changes
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Summary
rimraf dist/*now work whendistdirectory doesn't existTest plan
bun bd testUSE_SYSTEM_BUN=1(before fix)Fixes #26317
🤖 Generated with Claude Code