Skip to content

Conversation

@kagol
Copy link
Member

@kagol kagol commented Jan 29, 2026

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Adjusted the positioning of the close button in the image preview modal for improved visibility and accessibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the bug Something isn't working label Jan 29, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

Updated the close button in the image preview modal by changing its CSS class name, repositioning it with fixed layout instead of absolute positioning, and moving its DOM attachment from the modal element to the document body.

Changes

Cohort / File(s) Summary
Close Button Styling & Positioning
packages/fluent-editor/src/modules/custom-image/preview/preview-modal.ts
Updated close button class name from image-preview-close to tiny-editor-image-preview-close, changed positioning strategy from absolute (top: -40px, right: 0) to fixed (top: 20px, right: 20px), and moved DOM attachment from modal to document body.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A button once tucked away tight,
Now sits on the page, positioned just right,
From modal's embrace to the body it flew,
With a fresh class name and coordinates new,
The preview looks better—our work here is through! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kagol/fix-image-preview-button

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kagol kagol merged commit 02e0270 into dev Jan 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants