Skip to content

Conversation

@kagol
Copy link
Member

@kagol kagol commented Jan 23, 2026

PR

close #439

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #439

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

Release Notes

  • New Features
    • Enhanced file upload configuration with multi-select control. Upload components now support per-type settings to enable or disable multiple file selection for images, videos, and documents, providing greater flexibility in file upload workflows.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the enhancement New feature or request label Jan 23, 2026
@kagol kagol merged commit 9c58340 into dev Jan 23, 2026
1 check passed
@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce granular per-type multiple file selection configuration to the uploader. A new MultipleConfig type enables setting multiple as either a global boolean or per-UploadKind override, with a resolver method and demo configuration example showing the new capability.

Changes

Cohort / File(s) Summary
Core Implementation
packages/fluent-editor/src/modules/custom-uploader.ts
Introduces MultipleConfig type for global or per-UploadKind boolean configuration. Adds multiple option to FileUploaderOptions with resolver logic in resolveOptions. Implements public getMultiple(kind: UploadKind): boolean method to retrieve effective multi-select behavior.
Configuration and Integration
packages/fluent-editor/src/config/index.ts
Modifies inputFile to conditionally apply multiple attribute by calling this.quill.uploader.getMultiple(type) instead of always setting it.
Demo Configuration
packages/docs/fluent-editor/demos/file-upload.vue
Adds multiple configuration block under uploader settings with per-type flags: file: false, image: true, video: false.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A fluffy feature hops into view,
Per-type control—now files pick too!
Global or granular, the choice is yours,
The uploader dances through new doors! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kagol/uploader-support-multiple

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [Feature]: uploader支持根据file/image/video单独配置maxSize和multiple

2 participants