Skip to content

hack: add govulncheck wrapper with ignore list support #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AlexNPavel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hack: add govulncheck wrapper with ignore list support #595

AlexNPavel wants to merge 1 commit into from
+190 −0

Conversation

@AlexNPavel
Copy link
Contributor

@AlexNPavel AlexNPavel commented Jan 28, 2026 •
edited
Loading

Summary

  • Add a wrapper script (hack/govulncheck-wrapper.sh) that runs govulncheck with support for ignoring vulnerabilities that have no available fix
  • Uses govulncheck JSON output for reliable parsing
  • Only flags vulnerabilities where code actually calls the vulnerable function
  • Automatically flags previously-ignored vulnerabilities when a fix becomes available
  • Add make vulncheck target
  • Include configuration with current unfixable vulnerabilities in openshift/hive and tektoncd/pipeline

Test plan

  • Run make vulncheck and verify it passes
  • Run ./hack/govulncheck-wrapper.sh --verbose and verify output shows ignored vulnerabilities
  • Run ./hack/govulncheck-wrapper.sh --help and verify usage is displayed

@openshift-ci openshift-ci bot requested review from hoxhaeris and jupierce January 28, 2026 20:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2026
@AlexNPavel
Copy link
Contributor Author

AlexNPavel commented Jan 28, 2026

/hold
Requires openshift/release#74091

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2026
@AlexNPavel
Copy link
Contributor Author

AlexNPavel commented Jan 28, 2026

/cc @bradmwilliams

@openshift-ci openshift-ci bot requested a review from bradmwilliams January 28, 2026 20:45
@AlexNPavel
hack: add govulncheck wrapper with ignore list support
69779d4 
Add a wrapper script that runs govulncheck and filters out
vulnerabilities that have no available fix. The script:

- Uses govulncheck JSON output for reliable parsing
- Only flags vulnerabilities where code calls the vulnerable function
- Ignores listed vulnerabilities only if no fix is available
- Automatically flags when a fix becomes available

Includes configuration file with current unfixable vulnerabilities
in openshift/hive and tektoncd/pipeline dependencies.
bradmwilliams
bradmwilliams approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@bradmwilliams bradmwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to add the same script to our other repos as well?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexNPavel, bradmwilliams

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [AlexNPavel,bradmwilliams]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@AlexNPavel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/govulncheck 69779d4 link false /test govulncheck
ci/prow/security 69779d4 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@AlexNPavel
Copy link
Contributor Author

AlexNPavel commented Jan 28, 2026

Are you going to add the same script to our other repos as well?

That's my current plan. I would prefer to have it shared somewhere so we don't have to worry about updating all repos if we want to change something, but I'm not sure of a way to cleanly do that right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoxhaeris hoxhaeris Awaiting requested review from hoxhaeris

@jupierce jupierce Awaiting requested review from jupierce

1 more reviewer

@bradmwilliams bradmwilliams bradmwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bradmwilliams bradmwilliams

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexNPavel @bradmwilliams