Change the registry accessor functions in bootstrap/client to call c.freshenFromCache with the corresponding RegistryType. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S(), IPv4(), IPv6()) to call c.freshenFromCache with the corresponding RegistryType.
Previously, all types tried to freshen ServiceProvider, which wouldn't have existed if you hadn't accessed that Registry, and wouldn't cause the registry you asked for to be added to the cache. This means the disk cache wasn't used for any type other than ServiceProvider
Change all uses of ioutil.* to the calls in os.* and io.*.
In the comments for bootstrap/client.go, change "b := bootstrap.NewClient()" to "b := &bootstrap.Client{}" because bootstrap.NewClient() deesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the registry accessor functions in bootstrap/client (ASN(), DNS(), IPv4(), IPv6()) to call c.freshenFromCache with the corresponding RegistryType.
Previously, all types tried to freshen ServiceProvider, which wouldn't have existed if you hadn't accessed that Registry, and wouldn't cause the registry you asked for to be added to the cache. This means the disk cache wasn't used for any type other than ServiceProvider.
Change all uses of ioutil.* to the calls in os.* and io.*.
In the comments for bootstrap/client.go, change "b := bootstrap.NewClient()" to "b := &bootstrap.Client{}" because bootstrap.NewClient() deesn't exist.