Skip to content

fix(i18n): move keys to the correct scope #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 4 commits into from
Jan 30, 2026
Merged

fix(i18n): move keys to the correct scope #376

danielroe merged 4 commits into from
Jan 30, 2026
+12 −26

Conversation

@9romise
Copy link
Contributor

@9romise 9romise commented Jan 30, 2026 •
edited
Loading

related to #374
/cc @userquin

@vercel
Copy link

vercel bot commented Jan 30, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 30, 2026 3:05am
npmx.dev Ready Ready Preview, Comment Jan 30, 2026 3:05am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Jan 30, 2026 3:05am

Request Review

@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/es-419.json Localization changed, will be marked as complete.
lunaria/files/es-ES.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@userquin
Copy link
Contributor

userquin commented Jan 30, 2026 •
edited
Loading

arggg, I use Gemini PRO for both sorry 🙏 and didn't check the structure for es-419.json 🥺, looks like we also need to change "rw" and "ro" (just remove them, vue-i18n will use the English version), tomorrow will do a deep review to es.json.

userquin
userquin approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the structure I added was wrong...

LGTM

@danielroe danielroe added this pull request to the merge queue Jan 30, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2026
@danielroe danielroe added this pull request to the merge queue Jan 30, 2026
Merged via the queue into npmx-dev:main with commit fa1d83d Jan 30, 2026
13 checks passed
@9romise 9romise deleted the i18n/fix-es-419 branch January 30, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

+1 more reviewer

@userquin userquin userquin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@9romise @userquin @danielroe