feat: arabic i18n #274
feat: arabic i18n #274
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
rebased onto main, ready to merge! |
|
updated translation with latest strings, ready to merge 👍🏻 |
|
🚀 |
Head branch was pushed to by a user without write access
|
sorry, forgot to |
| name: 'English', | ||
| }, | ||
| { | ||
| code: 'ar-EG', |
There was a problem hiding this comment.
this should be ar not ar-EG, buildLocales will add ar-EG using both files
There was a problem hiding this comment.
mmm, that's what it was from the elk code, but it causes a type error 🤔
There was a problem hiding this comment.
you need to run pnpm nuxt prepare or start dev server, locales are typed at i18n
There was a problem hiding this comment.
still seems to give a type error. happens on CI too
There was a problem hiding this comment.
checking on my local, I changed the type
There was a problem hiding this comment.
oh shoot, commented in the same moment
yes vscode. before the error was on the string itself, now (idk what changed) it seems to be @intlify/core-base
and in a previous commit it failed in CI here too (on the type of the strring itself)
There was a problem hiding this comment.
arrggg missing @intlify/core-base, can you run pnpm add @intlify/core-base and commit and push package.json and pnpm-lock.yaml
There was a problem hiding this comment.
when'd that disappear! i just added it back, here's the error:
Type '"ar"' is not assignable to type '"ar-EG" | "de-DE" | "en-US" | "es-419" | "es-ES" | "fr-FR" | "it-IT" | "ja-JP" | "zh-CN"'.ts(2322)
module.d.mts(447, 5): The expected type comes from property 'code' which is declared here on type 'LocaleObjectData'
(property) LocaleObject<"ar-EG" | "de-DE" | "en-US" | "es-419" | "es-ES" | "fr-FR" | "it-IT" | "ja-JP" | "zh-CN">.code: "ar-" | "de-DE" | "en-US" | "es-419" | "es-ES" | "fr-FR" | "it-IT" | "ja-JP" | "zh-CN"
There was a problem hiding this comment.
apparently it was removed in 4ca6ce8, knip is now failing CI
|
Glad for the code changes too, will use these changes in #360 😉 |
4 participants
Adds Arabic locale. Stacked on top of #263, and can only be merged after its base PR is merged.
found_packagesin English to match, other languages may followpluralparameter to various$tcalls for pluralization to work- AddsFixed in main.search.header, used in the search results header, on all languages, copied fromnav.search.There's still nortlorlangwiring to thehtmlelement.That was part of #245, and may be redone as a separate PR.See #275.
Any UI adjustments for rtl will follow in a separate PR.