Skip to content

Conversation

@roxanebellot
Copy link

In order to make dev of python apps using netorcai easier, here is a few changes, mainly about understandability and readability

Changes

  • Pep8 compliance
  • all message now have a __repr__ so are human-readable when printed
  • list parsage in list comprehension instead of function -> more readable + more efficient

@roxanebellot roxanebellot force-pushed the more_pythonic_messages branch from 37f9e3c to eeeeacf Compare October 2, 2019 06:16
@codecov-io
Copy link

Codecov Report

Merging #2 into master will decrease coverage by 5.03%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #2      +/-   ##
=========================================
- Coverage   99.34%   94.3%   -5.04%     
=========================================
  Files           3       3              
  Lines         152     158       +6     
=========================================
- Hits          151     149       -2     
- Misses          1       9       +8
Impacted Files Coverage Δ
netorcai/message.py 86.88% <57.89%> (-13.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee88daa...eeeeacf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants