Skip to content

Conversation

@christiam
Copy link
Contributor

No description provided.

@christiam christiam requested a review from tom6931 June 11, 2020 17:59
@christiam christiam self-assigned this Jun 11, 2020
Copy link
Contributor

@tom6931 tom6931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the reason to add the --user flag is to produce files that belong to the user rather than root. I'm fine with this, but I don't have any insight into possible side-effects. Was this prompted by a complaint?

@boratyng
Copy link
Contributor

Yes, by default files created by docker container belong to root. This may be a problem if you do not have root permissions. These may be possible side effects:

  • problem if a user does not have read or write permissions to a local directory
  • problem if there is a need to modify a file that is a part of the image (I do not think this applies to us though)

@christiam christiam marked this pull request as draft June 12, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants