Skip to content

Conversation

@SajidMannikeri17
Copy link
Contributor

@SajidMannikeri17 SajidMannikeri17 commented Jan 27, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Relaxed validation requirements on client detail updates to allow submissions with zero user claims, while preserving the maximum threshold of 30 claims.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: SajidMannikeri17 <sajid.mannikeri@ad.infosys.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Walkthrough

The validation constraint on the userClaims field in ClientDetailUpdateRequest was relaxed by removing the minimum size requirement, allowing empty user claims lists while maintaining the maximum constraint of 30 entries.

Changes

Cohort / File(s) Summary
Validation Constraint Relaxation
esignet-core/src/main/java/io/mosip/esignet/core/dto/ClientDetailUpdateRequest.java
Removed min = 1 parameter from @Size annotation on userClaims field, now permits empty lists (0–30 entries instead of 1–30)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A constraint once firm, now gently unwinds,
Empty claims are welcome, no minimum binds,
Flexibility blooms in validation's embrace,
The userClaims field finds its freest space! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the minimum size constraint on userClaims to allow empty lists, fixing the inability to update signup-client without userClaims.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants