feat(fetch): add Dragonfly integration for accelerated blob downloads

[chlins]

This pull request introduces support for fetching model artifacts using Dragonfly via a gRPC endpoint, along with related configuration and implementation changes. The main goal is to allow users to specify a Dragonfly endpoint for efficient blob downloading and hardlinking, with pattern-based selection of layers. The changes also add progress reporting and extend the fetch configuration options.

Dragonfly integration for fetch operations:

• Added a new dragonfly-endpoint flag to the fetch command, enabling users to specify a Dragonfly gRPC endpoint for pulling and hardlinking blobs. (cmd/fetch.go)
• Updated the fetch logic to use the Dragonfly-based fetch path when a Dragonfly endpoint is provided. (pkg/backend/fetch.go)
• Implemented the full Dragonfly fetch workflow, including manifest parsing, pattern-matching layers, concurrent downloads, progress bar integration, and optional tar extraction. (pkg/backend/fetch_by_d7y.go)

Configuration enhancements:

• Extended the Fetch struct to include DragonflyEndpoint, ProgressWriter, DisableProgress, and Hooks fields, and set sensible defaults in NewFetch(). (pkg/config/fetch.go) [1] [2]
• Updated imports in pkg/config/fetch.go to support new features such as progress writing.

[gemini-code-assist]

Summary of Changes

Hello @chlins, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the artifact fetching capabilities by integrating Dragonfly, a P2P-based file distribution system. It enables users to leverage a specified Dragonfly gRPC endpoint for highly efficient and accelerated downloads of model artifacts, supporting selective layer fetching based on patterns and providing detailed progress feedback.

Highlights

• Dragonfly Endpoint Flag: A new --dragonfly-endpoint command-line flag has been introduced to enable Dragonfly integration for fetch operations, allowing users to specify the gRPC service address.
• Dragonfly Fetch Logic Integration: The core fetch mechanism has been modified to conditionally utilize Dragonfly for blob downloads and hardlinking when a Dragonfly endpoint is provided in the configuration.
• New Dragonfly Implementation File: A dedicated file, pkg/backend/fetch_by_d7y.go, has been added to encapsulate the complete Dragonfly fetch workflow, including manifest parsing, pattern-matching for layers, concurrent downloads, and progress reporting.
• Enhanced Fetch Configuration: The Fetch configuration struct has been extended with new fields for the Dragonfly endpoint, progress writer, disabling progress, and pull hooks, along with updated default initializations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a valuable feature by integrating Dragonfly for accelerated blob downloads. The implementation is well-structured, separating the Dragonfly-specific logic and providing a clear path for its use via a new command-line flag. The use of concurrent processing and progress reporting is also well-handled.

I've identified a few areas for improvement. The most critical is the use of an insecure gRPC connection to Dragonfly, which should be addressed to ensure security in production environments. Additionally, there are opportunities to improve code maintainability by refactoring duplicated logic for layer filtering and annotation handling. I've also noted the use of a deprecated gRPC function and a minor inconsistency in an error message.

Overall, this is a strong contribution. Addressing the feedback will enhance the robustness, security, and maintainability of the new functionality.

[gaius-qi]

LGTM

[aftersnow]

lgtm

[imeoer]

lgtm