-
Notifications
You must be signed in to change notification settings - Fork 0
REFACTOR: Manual-only update system as primary method #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Design Decision: Manual notifications as default instead of auto-updater fallback - Auto-updater completely disabled since we don't have code signing - Prevents background signature validation errors - Manual GitHub API system is now the primary and only update method - Much cleaner and more reliable for unsigned applications 🔧 Changes Made: - Disabled auto-updater initialization and event handlers - Redirected checkForUpdates() to manual system - Removed auto-download and auto-install functionality - Cleaned up signature error detection (no longer needed) - Simplified codebase by removing unused auto-updater complexity 💡 Benefits: - No more background signature validation failures - Cleaner, more predictable update experience - Smaller bundle size (removed auto-updater overhead) - Professional manual update notifications - Ready for future signed app transition 🚀 User Experience: - Settings > About > 'Check for Updates' button - GitHub API integration with version comparison - User-friendly dialogs with direct download links - No confusing error messages or failed background processes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. WalkthroughThis update removes all automatic update functionality from the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant GitHub API
User->>App: Initiate update check
App->>GitHub API: Request latest release info
GitHub API-->>App: Respond with release data
App->>User: Notify if update is available or not
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary
• Converted from hybrid auto-updater to manual-only update system as the primary method
• Completely disabled auto-updater to prevent signature validation errors
• Simplified codebase by removing 280+ lines of auto-updater complexity
• Manual GitHub API notifications are now the default and only update method
Rationale
Since we don't have Apple Developer certificates, the auto-updater always fails with signature errors. Instead of having a fallback system, it makes more sense to use the manual notification system as the primary method.
Key Changes
🚫 Auto-Updater Completely Disabled
🔄 Redirected API Calls
🧹 Cleaned Up Codebase
Removed:
Kept:
Benefits
🎯 User Experience
💻 Technical Benefits
🔮 Future-Ready
User Flow
Current Experience:
No More:
Technical Implementation
Simplified Architecture
vs. Previous Hybrid:
API Compatibility
checkForUpdates()redirects to manual systemTesting
Test Manual Updates:
Verify No Background Errors:
Bundle Size Impact
This approach provides a cleaner, more reliable update experience for unsigned applications while remaining ready for future code signing when available.
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes
Chores