Workbench - extract floating menu into a widget

[lszomoru]

No description provided.

[Copilot]

Pull request overview

This pull request refactors the floating editor toolbar by extracting the widget rendering logic from FloatingEditorToolbar into a new reusable FloatingEditorToolbarWidget class. This separation improves code organization and allows the widget to be reused in other contexts.

Changes:

• Created new FloatingEditorToolbarWidget class that encapsulates the toolbar widget's element creation, menu observation, and rendering logic
• Refactored FloatingEditorToolbar to instantiate and manage the widget, delegating the toolbar UI creation to the new widget class
• Modified the element lifecycle so it's created once in the widget constructor rather than being recreated on each menu change

Comments suppressed due to low confidence (1)

src/vs/editor/contrib/floatingMenu/browser/floatingMenu.ts:102

• Each time the toolbar is recreated, it's being added to the same this.element container without clearing previous content. This will cause the old toolbar's DOM nodes to remain in the element even though they're disposed, leading to DOM pollution. The element should be cleared before creating a new toolbar, or the toolbar should be created only once and updated reactively.

			const toolbar = instantiationService.createInstance(MenuWorkbenchToolBar, this.element, MenuId.EditorContent, {

[Copilot]

The menuId parameter is hardcoded as MenuId.EditorContent instead of using the _menuId parameter that is passed to the constructor. This makes the _menuId parameter effectively unused for the toolbar configuration, reducing the reusability of this widget. Use _menuId instead of MenuId.EditorContent.

Suggested change

	const toolbar = instantiationService.createInstance(MenuWorkbenchToolBar, this.element, MenuId.EditorContent, {
	const toolbar = instantiationService.createInstance(MenuWorkbenchToolBar, this.element, _menuId, {