Remove cyclic dependency on IAgentSessionsService in chat input part #289277
+4
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chatInputPart.tsdepends onagentSessionsService.modelto retrieve session file changes, creating a cyclic dependency:Since chatInputPart already belongs to a chatModel, this indirection is unnecessary and architecturally incorrect.
Changes
Removed
IAgentSessionsServicedependency fromChatInputPart:sessionFileChangesobservable (listening toagentSessionsService.model.onDidChangeSessions) with empty derived observableWhy this is safe:
sessionFilescan return empty array with no functional impactEliminates ~25 lines of complex observable logic and breaks the cyclic dependency.
Original prompt
IAgentSessionsService.model#283856✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.