Updates to prompt file location settings #289275
Open
+253
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates prompt file path handling to enforce cross-platform compatibility by restricting path configurations to forward slashes only. The changes introduce a new chat.agentFilesLocations configuration key to replace the deprecated chat.modeFilesLocations, implement simplified path validation that rejects backslashes, and add warnings for deprecated glob pattern usage in prompt locations.
Changes:
- Introduces
AGENTS_LOCATION_KEYconfiguration and deprecatesMODE_LOCATION_KEY - Updates path validation to reject backslashes and require forward slashes for cross-platform sharing
- Adds glob pattern detection and warning mechanism for prompt and instruction file locations
- Registers new internal command
_listExtensionPromptFilesto enumerate extension-contributed prompt files
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/promptSyntax/utils/promptFilesLocator.test.ts | Adds tests for backslash rejection and introduces comprehensive test suite for the new hasGlobPattern function |
| src/vs/workbench/contrib/chat/common/promptSyntax/utils/promptFilesLocator.ts | Implements hasGlobPattern function, warnForGlobPatterns method, and introduces VALID_SIMPLIFIED_PATH_PATTERN with isValidSimplifiedPath function while deprecating skill-specific naming |
| src/vs/workbench/contrib/chat/common/promptSyntax/config/config.ts | Introduces AGENTS_LOCATION_KEY, deprecates MODE_LOCATION_KEY, updates getPromptFileLocationsConfigKey to return new key, and restricts isTildePath to forward slashes only |
| src/vs/workbench/contrib/chat/common/promptSyntax/chatPromptFilesContribution.ts | Adds _listExtensionPromptFiles internal command that lists all extension-contributed prompt files across all prompt types |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Adds new chat.agentFilesLocations configuration schema with simplified path validation, updates skills configuration to use new pattern, and updates validation error messages |
src/vs/workbench/contrib/chat/common/promptSyntax/utils/promptFilesLocator.ts
Outdated
Show resolved
Hide resolved
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @rzhao271Matched files:
|
pwang347
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.