fix: treat provider-registered modes from default extension as built-in #289274
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a categorization issue where chat modes registered via the provider API from the default chat extension were incorrectly appearing in the "Custom" category instead of "Built-In" in the mode picker.
Changes:
- Modified the
isModeConsideredBuiltInfunction to accept bothcontributionandprovidersource types when determining if a mode from the default chat extension should be considered built-in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modes registered via the provider API (
ExtensionAgentSourceType.provider) from the default chat extension were not being recognized as built-in modes, causing them to appear in the "Custom" category instead of "Built-In" in the mode picker.This fixes the
isModeConsideredBuiltInfunction to also acceptprovidertype alongsidecontributiontype when the mode comes from the default chat agent extension.