Fix undefined access in viewModelLines.ts getViewLineMinColumn #289256
+51
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issues #213371 and #287067 where getViewLineMinColumn and similar methods could crash with "Cannot read properties of undefined" when modelLineProjections array is out of sync with projectedModelLineLineCounts due to race conditions during model updates. Added null checks in getViewLineContent, getViewLineLength, getViewLineMinColumn, getViewLineMaxColumn, and getViewLineData methods to return safe defaults when the line projection is undefined. Co-authored-by: bryanchen-d <41454397+bryanchen-d@users.noreply.github.com>
Address code review feedback: - Add null checks in getMinColumnOfViewLine, getMaxColumnOfViewLine, getModelStartPositionOfViewLine, and getModelEndPositionOfViewLine - Improve getViewLineData fallback to handle edge case where model has no lines by using Math.max/min to get safe line number Co-authored-by: bryanchen-d <41454397+bryanchen-d@users.noreply.github.com>
Remove unnecessary Math.max/min calculation since we just need line 1 tokens for the empty fallback ViewLineData. Co-authored-by: bryanchen-d <41454397+bryanchen-d@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unhandled error reading properties of undefined
Fix undefined access in viewModelLines.ts getViewLineMinColumn
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race condition causes
modelLineProjectionsarray to become out of sync withprojectedModelLineLineCountsduring model updates. When external callers (e.g.,mainThreadEditor.ts) invokegetVisibleRanges()during this window, accessingmodelLineProjections[modelLineNumber - 1]throws undefined error.Changes:
getModelLineProjection(modelLineNumber)helper that returnsundefinedwhen index is out of boundsgetViewLineContent→''getViewLineLength→0getViewLineMinColumn/getViewLineMaxColumn→1getViewLineData→ fallbackViewLineDatawith empty contentgetMinColumnOfViewLine,getMaxColumnOfViewLine,getModelStartPositionOfViewLine,getModelEndPositionOfViewLineWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
disallowed.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=12427 --enable-crash-reporter=0a6244d1-1868-4ba9-ba04-846583393c75,no_channel --user-data-dir=/tmp/vscode-tests-1768953438515 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2993599158436563845,1044423022455121245,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 /home/REDACTED/.co-auth .2 ldd x86-64.so.2 bash(dns block).build/electron/code-oss .build/electron/code-oss --no-sandbox test/unit/electron/index.js --crash-reporter-directory=/home/REDACTED/work/vscode/vscode/.build/crashes s/li�� nibrowser-wpe/install-dependencies.sh -v che/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell exit --run src/vXvfb .2 cal/bin/ldd che/ms-playwrigh0 nibr�� ound-networking ound-timer-throttcp tnet/tools/ldd orward-cache ad -side-phishing-dbash ent-extensions-w-c(dns block)example.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=12427 --enable-crash-reporter=0a6244d1-1868-4ba9-ba04-846583393c75,no_channel --user-data-dir=/tmp/vscode-tests-1768953438515 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2993599158436563845,1044423022455121245,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 /home/REDACTED/.co-auth .2 ldd x86-64.so.2 bash(dns block).build/electron/code-oss .build/electron/code-oss --no-sandbox test/unit/electron/index.js --crash-reporter-directory=/home/REDACTED/work/vscode/vscode/.build/crashes s/li�� nibrowser-wpe/install-dependencies.sh -v che/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell exit --run src/vXvfb .2 cal/bin/ldd che/ms-playwrigh0 nibr�� ound-networking ound-timer-throttcp tnet/tools/ldd orward-cache ad -side-phishing-dbash ent-extensions-w-c(dns block)mobile.events.data.microsoft.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=12427 --enable-crash-reporter=0a6244d1-1868-4ba9-ba04-846583393c75,no_channel --user-data-dir=/tmp/vscode-tests-1768953438515 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2993599158436563845,1044423022455121245,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 /home/REDACTED/.co-auth .2 ldd x86-64.so.2 bash(dns block).build/electron/code-oss .build/electron/code-oss --no-sandbox test/unit/electron/index.js --crash-reporter-directory=/home/REDACTED/work/vscode/vscode/.build/crashes s/li�� nibrowser-wpe/install-dependencies.sh -v che/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell exit --run src/vXvfb .2 cal/bin/ldd che/ms-playwrigh0 nibr�� ound-networking ound-timer-throttcp tnet/tools/ldd orward-cache ad -side-phishing-dbash ent-extensions-w-c(dns block)redirector.gvt1.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=10345 --enable-crash-reporter=0a6244d1-1868-4ba9-ba04-846583393c75,no_channel --user-data-dir=/tmp/vscode-tests-1768952977634 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4743992538289350805,14766294595139264140,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 x86-64.so.2 est/unit/browsersh ldd modules/@npmcli/node build/lib/electron.ts x86-64.so.2(dns block).build/electron/code-oss .build/electron/code-oss --no-sandbox test/unit/electron/index.js --crash-reporter-directory=/home/REDACTED/work/vscode/vscode/.build/crashes --run src/vs/editor/test/browser/viewModel/modelLineProjection.test.ts x86-64.so.2 cal/bin/ldd bin/ldd ldd run-script/lib/n--noprofile ldd nibr�� x86-64.so.2(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=10490 --enable-crash-reporter=0a6244d1-1868-4ba9-ba04-846583393c75,no_channel --user-data-dir=/tmp/vscode-tests-1768952988791 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4583171642203889526,10176158874905604066,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 n/ldd l to the X server" "/tmp/server-99.xkm" x86-64.so.2 x86-64.so.2 .2(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.