Support multi window scenarios in vscode mcp server #289250
Open
+337
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds multi-window support to the VS Code MCP (Model Context Protocol) server by introducing window management tools and enhancing the PlaywrightDriver to handle multiple windows/pages.
Changes:
- Added window management tools for listing, switching between, and interacting with multiple VS Code windows
- Modified PlaywrightDriver to support dynamic window switching by making the current page mutable
- Enhanced automation capabilities with window-specific operations (screenshots, accessibility snapshots, clicks, typing, etc.)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/mcp/src/automationTools/windows.ts | New file introducing 10 window management tools including list, switch, screenshot, snapshot, click, type, evaluate, locator info, and wait operations |
| test/mcp/src/automationTools/index.ts | Integrates and exports the new window management tools |
| test/automation/src/playwrightDriver.ts | Refactors page field to support window switching; adds 8 new methods for multi-window operations including getAllWindows, switchToWindow, getWindowsInfo, screenshotBuffer, and element interaction helpers |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
…89261) * Initial plan * Address code review feedback: improve URL matching and CDP session handling - Improve URL matching in switchToWindow to prefer exact matches before substring matches - Clear CDP session when switching windows to prevent using stale sessions - Add comprehensive documentation explaining the matching strategy and CDP session behavior Co-authored-by: rebornix <876920+rebornix@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rebornix <876920+rebornix@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.