feat: add domain name validation regex and unit tests #1043
+57
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds domain name format validation to the Power Platform environment resource by introducing a regex pattern that enforces domain names to start with a lowercase letter and contain only lowercase letters, numbers, and hyphens. The PR adds corresponding unit tests to verify valid and invalid domain formats.
Changes:
- Added
DomainNameRegexconstant to enforce domain naming rules - Applied regex validation to the
dataverse.domainattribute in the environment resource schema - Added two unit tests: one for valid domain format and one for invalid characters
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/helpers/regex.go | Added new DomainNameRegex constant with pattern ^[a-z][a-z0-9-]*$ |
| internal/services/environment/resource_environment.go | Applied RegexMatches validator to domain attribute with descriptive error message |
| internal/services/environment/resource_environment_test.go | Added two unit tests for domain format validation: one with valid format and one with invalid characters |
…produced-inconsistent-result-after-apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1031
Added a domain format regex and apply it to
dataverse.domainvalidation in the environment resource.Added unit tests to cover valid lowercase domains and invalid domain characters.