-
Notifications
You must be signed in to change notification settings - Fork 5k
feat: add request.body async getters #38718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The failing BiDi tests are all passing locally. CI test results seem flakier than they used to be, perhaps due to the increased number of workers. |
403a72b to
07ca85e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@hbenl mind checking the BiDi job? Two tests are failing - maybe intermittently? |
07ca85e to
d1fbd19
Compare
|
Those failures are unrelated to this PR, the tests are also failing in other test runs, I've added them to the expectations file. |
Test results for "tests 1"6 failed 5 flaky34681 passed, 691 skipped Merge workflow run. |
Test results for "MCP"1 failed 2829 passed, 121 skipped Merge workflow run. |
Interesting. Do we know since when they started to fail and what caused them given that we were probably green about 4 weeks ago? Or are they new and were not added to the expectation list? |
One of them is new and has been failing intermittently from the start, the other started failing on 2026-01-09. I'll investigate. |
|
The 2 failures in the latest run are from new tests that have been failing before (one of them intermittently). |
Fixes #38150 and the following tests:
with Chrome/CDP:
page/network-request-body.spec.ts:with BiDi:
page/network-request-body.spec.ts: