Skip to content

Conversation

@An631
Copy link
Contributor

@An631 An631 commented Jan 29, 2026

Overview

Addresses #772 by adding the testPathPatterns (plural) as a valid arguments option. This makes just compatible with jest 30 which updated testPathPattern to be testPathPatterns

Test Notes

Ran yarn test.

@An631 An631 reopened this Jan 29, 2026
@An631 An631 marked this pull request as ready for review January 29, 2026 23:24
/**
* Compatible with jest 30+ only
*/
testPathPatterns?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the type an array or a string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm good question, from what I see in the documentation it looks like multiple strings separated by spaces:
image

I wonder how the parsing of arguments works in that case. Let me look deeper into it and come back with an answer

Copy link
Contributor Author

@An631 An631 Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so from the documentation I also see that they define the property as a regex expression:

image

https://jestjs.io/docs/cli#--testpathpatternsregex

So I believe using string is the right type based on that.

@christiango christiango merged commit 98eb25c into microsoft:main Jan 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants