Skip to content

Conversation

@skupriienko
Copy link
Collaborator

@skupriienko skupriienko commented Dec 5, 2025

Links:

Actions:

  • Add missing endpoints:

    • Add "users", "me" to the users key of special cases in the class Config.
    • Add handle_users to mailgun.handlers.users_handler for parsing Users API.
    • Add handle_mailboxes_credentials() to mailgun.handlers.domains_handler for parsing Update Mailgun SMTP credentials in Credentials API.
    • Update handle_templates() in mailgun/handlers/templates_handler.py to handle new_tag
  • Examples:

    • Move credentials examples from mailgun/examples/domain_examples.py to mailgun/examples/credentials_examples.py and add a new example put_mailboxes_credentials().
    • Add the get_routes_match() example to mailgun/examples/routes_examples.py
    • Add the update_template_version_copy() example to mailgun/examples/templates_examples.py
    • Add mailgun/examples/users_examples.py
  • Docs:

    • Add Credentials and Users sections with examples to README.md.
    • Add docstrings to the test class UsersTests & AsyncUsersTests and theirs methods.
  • Tests:

    • Add test_put_mailboxes_credentials to DomainTests and AsyncDomainTests
    • Add test_get_routes_match to RoutesTests and AsyncRoutesTests
    • Add test_update_template_version_copy to TemplatesTests and AsyncTemplatesTests
    • Add classes UsersTests and AsyncUsersTests to tests/tests.py.
  • CI:

    • Update pre-commit hooks to the latest versions.
    • Add pytest-order as an mypy's additional_dependencies in .pre-commit-config.yaml to suppress error: Untyped decorator makes function
  • Linting & Formatting:

    • Replace spaces with tabs in Makefile
    • Run linter & formatters commands.
  • Package Management:

    • Update the changelog.

@skupriienko skupriienko self-assigned this Dec 5, 2025
@skupriienko skupriienko marked this pull request as ready for review December 9, 2025 20:30
@skupriienko skupriienko requested a review from erz9engel December 9, 2025 20:31
Copy link
Collaborator

@erz9engel erz9engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! great job!

@skupriienko skupriienko merged commit 0cae25c into main Dec 10, 2025
17 checks passed
@skupriienko skupriienko deleted the Add-missing-endpoints branch December 10, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants