fix/onchain-fee-calculation-to-support-fractional-cents #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed onChainUsdTxFee to use FractionalCentAmount instead of CentAmount - Removed Math.round() that was losing decimal precision from Ibex API - Updated both main and quickstart GraphQL schemas - Aligns with existing pattern used in LnNoAmountUsdInvoiceFeeProbe
brh28
reviewed
Jan 16, 2026
Contributor
brh28
left a comment
brh28
left a comment
There was a problem hiding this comment.
LGTM. Have you been able to test this locally?
islandbitcoin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #117