Fix Could NOT find OpenMP_CUDA (missing: OpenMP_CUDA_FLAGS OpenMP_CUD… #203
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirrgang
reviewed
Jan 26, 2026
src/CMakeLists.txt
Outdated
|
|
||
| find_package(CUDA 11.7 REQUIRED) | ||
| find_package(OpenMP REQUIRED) | ||
| find_package(OpenMP REQUIRED C CXX) |
There was a problem hiding this comment.
Requiring the C component is unnecessary and introduces unnecessary dependencies that caused grief in some environments I had to build for.
Explicitly using the "COMPONENTS" key word is technically optional, but improves readability.
Suggested change
| find_package(OpenMP REQUIRED C CXX) | |
| find_package(OpenMP REQUIRED COMPONENTS CXX) |
Author
There was a problem hiding this comment.
You are correct, I tested it without the C and it still works. It's obviously just the missing CXX that causes the problem. I've amended the PR
…A_LIB_NAMES) This is a fix for llnl#124 The solution to the issue originally was to stay on a specific cmake version. That's inconvenient. This fixes the problem so that newer versions of cmake work correctly. It is based on the discussion and solution found at NVIDIA/cuda-samples#333. I've tested it with cmake 4.2 and CUDA Toolkit 12.9 on Windows, but that thread indicates it resolves the problem in 3.31, 4.0 and 4.1 (on arch linux).
ChrisJD-VMC
force-pushed
the
fix-missing-OpenMP_CUDA_FLAGS
branch
from
4cb1e17 to
7cb63b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Could NOT find OpenMP_CUDA (missing: OpenMP_CUDA_FLAGS OpenMP_CUDA_LIB_NAMES)
This is a fix for #124 The original solution to the issue was to stay on a specific cmake version. That's inconvenient. This fixes the problem so that newer versions of cmake work correctly. It is based on the discussion and solution found at NVIDIA/cuda-samples#333.
I've tested it with cmake 4.2 and CUDA Toolkit 12.9 on Windows with VS 2022, but that thread indicates it resolves the problem in 3.31, 4.0 and 4.1 (on arch linux).