feature easy-trash module #229
Open
+172
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Auto.drop.mp4Auto.inv.drop.mp4 |
beanbag44
requested changes
Jan 26, 2026
Member
beanbag44
left a comment
beanbag44
left a comment
There was a problem hiding this comment.
Really handy module, just some small nit picks and changes
|
|
||
| init { | ||
| listen<TickEvent.Pre> { | ||
| if (!timer.timePassed(200.milliseconds)) { |
Member
There was a problem hiding this comment.
we have an actions per second timer in the inventory config. I'd set the default value to this and let the inventory manager handle the delay
Contributor
Author
There was a problem hiding this comment.
How would I use the inventory request limit? Just spam inventory requests every tick?
Member
There was a problem hiding this comment.
yeah, all requests are expected to be sent on a tickly basis to stay up to date with the rest of the game
emyfops
requested changes
Jan 27, 2026
Use @WrapMethod in mixin Other nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module adds a feature to auto drop items when you don't have space in your inventory