Ref: Mixin cleanup #228
Merged
Ref: Mixin cleanup #228
+109
−251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why you would use this over |
0-x-2-2
suggested changes
Jan 27, 2026
0-x-2-2
left a comment
0-x-2-2
left a comment
There was a problem hiding this comment.
Most of these are wrong, and you shouldn't replace some of these. @Inject is perfectly safe and likely what you want most of the time.
|
Most of this is just abusing the feature. |
|
But many of the old injections were also wrong and should have been using some other feature from mixinextras. |
Collaborator
Author
|
I mistakenly took an error from last year and attributed to |
This reverts commit 4d0eac6.
emyfops
changed the title
Collaborator
Author
|
I've tested for potential breaking changes and they're all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the nature ofInject, they can cause mixin conflicts with mods that aren't up to date or don't use mixinextra features. This pull request replaces most injections by wrapping operationsThis pull request needs extensive testing as it may break current features and introduce logic bugsThis pull request cleans up the mixins and replaces some mixins with less intrusive ones