Scene definitions cleanup #626
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: twells <twells@kipr.org>
|
Cursor Agent can help with this pull request. Just |
…ervo state access methods
…s, updating completion criteria, and improving can upright detection in the scene.
… events, introducing intersection events for cans, and enhancing upright detection. Update success and failure conditions accordingly.
… can stacking and robot interactions, updating success and failure conditions, and improving geometry definitions for better clarity and functionality
twells46
force-pushed
the
cursor/scene-definitions-cleanup-7dfb
branch
from
9b22f4a to
b2c1559
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up JBC challenges 11, 14-23 scene definitions by centralizing common components and removing unused imports.
This PR extracts repetitive
notInStartBoxscript and related geometry/node definitions intojbcCommonComponents.tsfor applicable challenges, and removes various unused imports across all specified challenge files. This aligns with previous cleanup efforts in PRs 607 and 625 to reduce redundancy and improve maintainability.