Skip to content

Conversation

@antikaspar
Copy link

@antikaspar antikaspar commented Nov 12, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

This PR adds an optional key lfsCheckout to the frogbot-config that can be used with the git- parameters. This should serve as a workaround (e.g. in yarn projects) since the go git-client doesn't support git lfs commands. By setting above parameter to true frogbot attempts to use the host installation of git to perform a git lfs pull after cloning the repository.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@antikaspar
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@antikaspar
Copy link
Author

recheck

@antikaspar
Copy link
Author

antikaspar commented Nov 14, 2025

@eranturgeman or @eyalk007 Could you have a look here please. This would greatly benefit our use case and not affect other functionality

@eyalk007
Copy link
Collaborator

hey @antikaspar , can you please explain what is the use case?

@eyalk007
Copy link
Collaborator

eyalk007 commented Dec 1, 2025

closing this pr as it is become stale

@eyalk007 eyalk007 closed this Dec 1, 2025
@antikaspar
Copy link
Author

Probably futile now but: in projects managed with yarn where dependencies are stored in git-lfs we need to be able to fetch them via git lfs. However this is not supported by the go package that frogbot is using. BUT since git lfs is most probably installed on every build host we use this one. It's a bit hackish but serves the purpose.

@tim-goto
Copy link

Hey @eyalk007 can you please re-open the pr or provide some feedback how we should tackle this? Thanks!

@eyalk007 eyalk007 reopened this Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants