Unified build system with lsof support #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes: - Unified Containerfiles: debian/ (debian+ubuntu), rocky/ (rocky) - New build syntax: ./build.sh -d DISTRO -v VERSION - Registry config: ~/.secrets/testing-containers-registry.conf - Image naming: distro-ssh:version (e.g., rocky-ssh:9, not rocky9x-ssh) - Removed old version-specific directories New workflow: source ~/.secrets/testing-containers-registry.conf gitea ./build.sh -d debian -v 13 ./run-podman.sh -d debian -v 13 Tested: debian-ssh:13 builds and pushes to Gitea successfully 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Changed run-podman.sh to require -d and -v flags (no defaults). Rebuilt debian-ssh:13 successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Added lsof to debian/Containerfile package list. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Added lsof package to debian/Containerfile (Debian & Ubuntu) - Added lsof package to rocky/Containerfile (Rocky Linux) - Added registry login to run-podman.sh for authenticated pulls - Updated README.md with new -d/-v syntax and sanitized registry config - Verified: debian-ssh:12, debian-ssh:13, rocky-ssh:9 all have lsof working 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor build system to use unified Containerfiles with flag-based syntax and add lsof package to all containers.
Changes
Build System Refactoring
./build.sh -d <distro> -v <version>(replaces./build.sh debian12-ssh)debian/Containerfilefor Debian & Ubuntu (with DISTRO_BASE/DISTRO_VERSION args)rocky/Containerfilefor Rocky Linux (with DISTRO_VERSION arg)rocky-ssh:9(dropped 'x' from rocky9x-ssh)~/.secrets/testing-containers-registry.confPackage Additions
lsofto debian/Containerfile (Debian & Ubuntu)lsofto rocky/Containerfile (Rocky Linux)ps(procps/procps-ng)Documentation
-d/-vsyntaxTesting
Verified on GitHub Container Registry:
Files Modified
build.sh- Complete rewrite with flag parsingrun-podman.sh- Flag parsing + registry authdebian/Containerfile- Added lsof packagerocky/Containerfile- Added lsof packageREADME.md- Updated documentationBreaking Changes
./build.sh debian12-ssh) no longer supported./build.sh -d debian -v 12🤖 Generated with Claude Code