Add Spark job descriptions and tweak debug logging #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since SparkContext.setJobDescription() sets a thread-local variable, we'll need to make sure to reset the description once each task finishes. This context manager should help with that.
ccdavis
approved these changes
Nov 21, 2025
Contributor
ccdavis
left a comment
ccdavis
left a comment
There was a problem hiding this comment.
The context manager approach is really nice. I think it makes code where it is used more readable too, besides making the running jobs easier to interpret. I want to see how an Hlink log looks and the Spark UI. Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #227.
This adds an
hlink.linking.util.set_job_description()function which you can use as a context manager to update Spark's job description. This is a thread-local variable which is displayed in the Spark UI. I chose a context manager for this because theSparkContext.setJobDescription()function sets the description for all following jobs until you callsetJobDescription(None). Using a context manager is a simple way to make sure we're doing this everywhere.I also removed some verbose debug logging and added some more logging in some spots.