Skip to content

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jan 19, 2026

Issue number: N/A


What is the current behavior?

The inner structural elements of item are not exposed as shadow parts, preventing users from being able to customize their styles directly.

What is the new behavior?

  • Exposes inner and content shadow parts
  • Adds e2e test coverage for customizing the shadow parts
  • Removes css variables test, combining it with the shadow parts test

Does this introduce a breaking change?

  • Yes
  • No

@vercel
Copy link

vercel bot commented Jan 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
ionic-framework Ready Ready Preview, Comment Jan 19, 2026 9:43pm

Request Review

@github-actions github-actions bot added the package: core @ionic/core package label Jan 19, 2026
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted this test because it doesn't do anything except set CSS variables so I added the same check here: https://github.com/ionic-team/ionic-framework/pull/30927/changes#diff-ede714f4c0e943356ae72d2456093d9e6ccc4e6fc86b465f598231be62a3ae8fR111

@brandyscarney brandyscarney marked this pull request as ready for review January 20, 2026 15:32
@brandyscarney brandyscarney requested a review from a team as a code owner January 20, 2026 15:32
@brandyscarney brandyscarney requested a review from gnbm January 20, 2026 15:32
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants