Fix pipeline restart logic in depl watch #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Added restart_requested atomic boolean to RunEnvironment - Background file watcher sets flag when files change - Pipeline checks flag after each action completes - Restarts gracefully except for last action and Observe actions - Removed immediate interruption with tokio::select This ensures clean state transitions and prevents corruption of build artifacts or partial operations.
Changes: - Removed Observe action exception from restart check - Modified ObserveAction.execute to monitor restart flag in background - Uses tokio::select to wait for either action completion or restart signal - If restart requested during Observe, interrupts cleanly and returns This allows long-running Observe actions (like npm run dev) to be interrupted when files change, enabling proper pipeline restart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.