-
Notifications
You must be signed in to change notification settings - Fork 0
Media module updates #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dmontesi
commented
Jan 6, 2026
- Added Wistia media module
- Added YouTube playlist media module
- Fix minor width bug that happened on first load
✅ Deploy Preview for imarc-pronto ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for Wistia and YouTube playlist media modules, and fixes a width rendering bug on first load by adding explicit width/height attributes to images.
Changes:
- Added two new Vue components: PWistia and PYouTubePlaylist with corresponding HTML templates
- Added explicit width and height attributes to all media placeholder images to prevent layout shifts
- Updated CSS with new styles and layout rules for the new media components
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/styles/atoms/media/media.html | Added width/height attributes to placeholder images |
| resources/styles/atoms/media/media-PYouTubePlaylist.html | New template for YouTube playlist media module |
| resources/styles/atoms/media/media-PYouTube.html | Added width/height attributes to placeholder images |
| resources/styles/atoms/media/media-PWistia.html | New template for Wistia media module |
| resources/styles/atoms/media/index.scss | Added extensive styling for new components with sizing and iframe positioning |
| resources/js/index.js | Registered PYouTubePlaylist and PWistia components |
| resources/js/components/PYouTubePlaylist.vue | New Vue component for YouTube playlists |
| resources/js/components/PYouTube.vue | Minor style change (double semicolon added) |
| resources/js/components/PWistia.vue | New Vue component for Wistia videos |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.