Migrate to poetry #2
Conversation
- black - mypy - isort - flake8
- Can be useful to share the configuration
|
For the moment, the linters output some errors. I will have to fix them. |
|
@iMicknl https://github.com/iMicknl/python-tahoma-api/pull/2/files#diff-b30393141377169ab3c3dc6750a3f3c0L119 I cannot find any Command class. Did you forget it or it's a mistake? |
|
it's in another branch: add_command_implementation |
|
@vlebourl Thx. I will have to include it otherwise the check will not pass. I've clean all the remarks except this one. |
|
Can you add a |
|
@vlebourl The pre-commit configuration has its own file. According to its author it's because this framework is not Python specific, and so nodejs user for instance does not care about setup.cfg. |
|
@iMicknl I've commented the method using the Command type. You will have to rebase on the master branch to get my work. |
vlebourl
left a comment
vlebourl
left a comment
There was a problem hiding this comment.
I've been looking at poetry for a while, I guess this is a good way to start dipping into it!
|
|
||
| # Development | ||
|
|
||
| ## Installation |
There was a problem hiding this comment.
Dev on VSCode follows this method?
There was a problem hiding this comment.
Yes the installation part is not linked to any IDE. That's the workflow I usualy follow. You should be able to start from scratch in 5 min only.
There was a problem hiding this comment.
I use PyCharm any ways, so method 2 is good enough for me!
You have to know a little setup.py to enjoy the real power of Poetry :D |
Migrate to Poetry
Add pre-commit with some linters:
Add Pycharm configuration to ease the development setup
Update the README.md to explain how to contribute to this project