-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Course completion: implemented RAG chatbot features #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ell-716
wants to merge
19
commits into
https-deeplearning-ai:main
Choose a base branch
from
Ell-716:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Modified search_tools.py to include lesson links in sources - Updated script.js to render sources as clickable links - Added pill-button styling for sources in style.css Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds a "+ NEW CHAT" button above the Courses section that clears the current conversation and starts a fresh session without page reload. Includes backend endpoint to clean up old sessions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Removed border and adjusted styling so the + New Chat button visually matches the Courses and Try Asking collapsible headers. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The RAG chatbot was returning "query failed" for all content queries because MAX_RESULTS was set to 0 in config.py, causing ChromaDB to return 0 results for every search. Changed MAX_RESULTS from 0 to 5. Added comprehensive test suite with 40 tests covering: - Config validation (catches misconfigurations like this bug) - CourseSearchTool.execute() behavior - AIGenerator tool calling integration - RAGSystem query orchestration Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Enable up to 2 sequential tool call rounds so Claude can reason about results and make follow-up tool calls for complex queries. The key fix ensures tools are included in follow-up API calls, allowing multi-step reasoning. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add test_api.py with 20 tests for FastAPI endpoints (/api/query, /api/courses, /api/session) using inline test app to avoid static file mount issues - Enhance conftest.py with shared fixtures for mock RAGSystem, SessionManager, and configuration - Update pyproject.toml with pytest-asyncio settings and cleaner test output configuration Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add theme toggle button with sun/moon icons in top-right corner - Implement light theme CSS variables with AAA contrast ratios - Add JavaScript for theme switching with localStorage persistence - Include smooth icon rotation animation on toggle - Ensure keyboard accessibility (Tab, Enter, Space support) - Use 44x44px touch target for WCAG compliance - Document all changes in frontend-changes.md Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add black and ruff to dev dependencies in pyproject.toml - Configure black (88 char lines, py313) and ruff (pycodestyle, pyflakes, isort, flake8-bugbear, comprehensions, pyupgrade) in pyproject.toml - Create development scripts: format.sh, lint.sh, quality.sh - Format entire codebase with black and fix all ruff lint issues - Modernize type annotations (List -> list, Dict -> dict, Optional -> |) - Add proper exception chaining (raise ... from e) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…63961 Add Claude Code GitHub Workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.