feat: ignore completed/scrapped blockers in isBlocked filter #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Core.IsBlocked() method that only considers active blockers (non-completed, non-scrapped) - Add Core.FindActiveBlockers() to retrieve active blockers for a bean - Simplify graph filters to use the new Core method for clean separation of concerns - Add comprehensive tests at both beancore and GraphQL resolver levels - Beans with completed/scrapped blockers now appear in `beans list --ready` Fixes bean-qfjl
- Remove duplicated loop logic in IsBlocked() - Delegate to FindActiveBlockers() and check length - Reduces IsBlocked from 30 lines to 4 lines Refs: beans-qfjl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modified the
isBlockedfilter logic to only consider active blockers (with status notcompletedorscrapped). This means beans with completed/scrapped blockers now correctly appear inbeans list --ready.Closes #68
Changes
Core.IsBlocked()andCore.FindActiveBlockers()methods to beancore layerTesting
All tests pass. Manual CLI testing confirms expected behavior:
--ready--ready