fix: add complete cycle detection for blocked_by relationships #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed AddBlockedBy to check cycles in both blocking and blocked_by graphs - Updated AddBlocking to also check blocked_by for cross-relationship cycles - Added cycle validation to CreateBean when blocked_by is provided - Added validation that blocking/blocked_by targets exist at creation time - Updated DetectCycle in beancore to support blocked_by link type - Added comprehensive tests for cycle detection scenarios: - blocked_by-only cycles - cross-relationship cycles (blocking ↔ blocked_by) - self-reference prevention - nonexistent bean validation Refs: #62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed incomplete cycle detection that previously allowed cycles to be created using only
blocked_byrelationships or mixingblockingandblocked_byin ways that created conflicts.Changes
blockingandblocked_bygraph traversalsCreateBeanto verify targets exist and check for immediate cyclesAddBlockingto detect cycles viablocked_byrelationships and vice versaAll tests pass.