fix: address issues #37, #39, #40 #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #37 - Golden image outdated: - Add create-golden-image.sh script to create new golden images - Script installs Bun, Node.js, Claude Code, and vers-agent - Configures systemd service and creates Vers commit Issue #39 - vm-sync fails when golden commit is not a git ancestor: - Detect when base commit is not a valid git commit - Detect when base commit is not an ancestor of HEAD - Automatically fall back to full sync mode (tarball upload) - Add --full flag to force full sync - Update vm-sync-all with same logic - Update help text Issue #40 - Claude subprocess restart is flaky: - Add cleanupOrphanedProcesses() to kill orphaned claude-code-acp processes - Call cleanup before starting new agent subprocess - Detect orphaned processes by checking if parent is dead 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses three related issues with VM orchestration and subprocess management:
Issue #37 - Golden image outdated
scripts/create-golden-image.shscript to create new golden imagesVERS_GOLDEN_COMMIT_IDto useIssue #39 - vm-sync fails when golden commit is not a git ancestor
vm-syncnow detects when the base commit is not a valid git commit--fullflag to force full sync modevm-sync-allwith the same logicIssue #40 - Claude subprocess restart is flaky
cleanupOrphanedProcesses()function to kill orphaned claude-code-acp processesTest plan
vm-syncwith invalid base commit - should fall back to full syncvm-sync --full- should use tarball uploadvm-syncwith valid git commit - should use bundle modecreate-golden-image.shto create a new golden imageRelated Issues
Closes #37
Closes #39
Closes #40
🤖 Generated with Claude Code