fix(session): always set currentId in handleSessionNew (#38) #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, sessionManager.setSession() was only called when claudeId was truthy. When getAgentSessionId() provided the session ID instead, setSession() was never called, leaving currentId as null. This caused session outputs to not be stored. The fix ensures setSession() is always called with the resolved newSessionId, regardless of which source provided it. Bug reproduction: 1. Agent subprocess already running (reused) 2. handleSessionNew called 3. claudeId is null (no notification yet) 4. getAgentSessionId() returns valid ID 5. setSession() was NOT called → currentId stays null 6. Outputs not stored due to null session ID check Adds comprehensive tests: - 27 unit tests for SessionManager - 2 integration tests that fail without the fix - Test plan document 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #38 - Session outputs not stored due to missing
currentSessionIdRoot cause: In
handleSessionNew,sessionManager.setSession()was only called whenclaudeIdwas truthy. WhengetAgentSessionId()provided the session ID instead,setSession()was never called, leavingcurrentIdas null.The fix: Always call
setSession(newSessionId)regardless of which source provided the ID.Bug reproduction
handleSessionNewcalledclaudeIdis null (no notification received yet)getAgentSessionId()returns valid ID from ACP session/new responsesetSession()was NOT called →currentIdstays nullgetCurrentSessionId()returns null insendSessionNotification"No currentSessionId, skipping storage"Changes
src/server/handlers/session.ts- Always callsetSession(newSessionId)Test plan
Verification
Tested on VM restored from golden commit
5931196c-f901-41eb-845d-859d279a168e:Without the fix, these would be
null.🤖 Generated with Claude Code