Skip to content

Conversation

@uh-oh-monteiro
Copy link

@uh-oh-monteiro uh-oh-monteiro commented Jul 25, 2025

  • there is a redundant block (its called later anyway) which should be removed
  • function call incorrectly nested (not sure why, but it works with the shown change). No adverse effects

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16510796558

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 61.468%

Totals Coverage Status
Change from base Build 14852644542: 0.04%
Covered Lines: 4698
Relevant Lines: 7643

💛 - Coveralls

self.tear_down_plugs()
raise
self.update_plug(plug_type, plug_instance)
self.update_plug(plug_type, plug_instance)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo i think the actual fix is to not call update_plug in add_non_managed_plug and tear_down_plugs for the unmanaged plugs, but this theoretically does the same thing. We might run into some edge case later on because the non-managed plugs are added to plugs_by_type and _by_name earlier than the managed plugs, but it's probably fine

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to implement when I've got more time :)

@uh-oh-monteiro uh-oh-monteiro merged commit b2e1ad4 into halter-mods Jul 25, 2025
14 checks passed
@uh-oh-monteiro uh-oh-monteiro deleted the fix/halter-multiplug-instantiation branch July 25, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants