-
Notifications
You must be signed in to change notification settings - Fork 438
impl(v3): update dockerfiles used in CI #15903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl(v3): update dockerfiles used in CI #15903
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Dockerfiles used in the CI pipeline to reflect current library versions and dependency requirements. The primary changes involve upgrading the Abseil-cpp library to a newer release and completely removing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Dockerfiles used in CI, primarily focusing on updating the Abseil C++ library version and streamlining dependency installations. The Abseil library is updated to 20250814.1 across all Dockerfiles where it's built from source. Additionally, the ABSL_PROPAGATE_CXX_STD=ON CMake flag has been removed from Abseil builds, and in some cases, -DCMAKE_CXX_STANDARD=17 is explicitly added. A significant change is the consistent removal of crc32c installation or build steps from almost all Dockerfiles.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15903 +/- ##
======================================================
- Coverage 92.83% 92.82% -0.01%
======================================================
Files 2354 2354
Lines 216302 216302
======================================================
- Hits 200804 200783 -21
- Misses 15498 15519 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4447f67
into
googleapis:prepare-for-v3.0.0
No description provided.