fix(java): Add validation layer to PromptMetadata.fromConfig() #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PromptMetadata.fromConfig()before performing unchecked castsProblem
The
fromConfig()method had 8+ unsafe casts that could causeClassCastExceptionat runtime when YAML frontmatter contained incorrectly typed values. For example, iftools: "not-a-list"was in YAML, the code would crash with a genericClassCastException.Solution
Added validation methods that:
instanceofchecks before castingIllegalArgumentExceptionwith detailed error messages like:input,output) with appropriate validationTest Coverage
Created
PromptMetadataTest.javawith 42 tests:Files Changed
PromptMetadata.java: AddedvalidateConfigTypes()andvalidateFieldIfPresent()methodsPromptMetadataTest.java: New comprehensive test fileBUILD.bazel: Added test target🤖 Generated with Claude Code