fix: add cycle detection to partial resolution across all runtimes #431
+411
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MengqinShen
approved these changes
Jan 23, 2026
yesudeep
force-pushed
the
yesudeep/fix/complex-plants
branch
from
3572bce to
3944bb1
Compare
yesudeep
changed the title
yesudeep
force-pushed
the
yesudeep/fix/complex-plants
branch
from
3944bb1 to
3a1356f
Compare
The Rust implementation of resolve_partials only resolved one level of partials, unlike Python, Java, Go, and JS which all recursively resolve the entire partial tree. Additionally, none of the runtimes had explicit cycle detection, which could cause infinite recursion when partials reference each other (e.g., A -> B -> A). This fix: Rust: - Refactors resolve_partials to use a new resolve_partials_recursive helper - Adds cycle detection using a HashSet to prevent infinite loops - Recursively resolves partials in resolved content to handle deep trees Python, Go, JS, Java: - Adds explicit cycle detection using a 'visited' set to track partials currently being processed: - Python: Added 'visited' parameter to _resolve_partials - Go: Added resolvePartialsRecursive helper with 'visited' map - JS: Added 'visited' Set parameter to resolvePartials - Java: Added overloaded resolvePartialsAsync with ConcurrentHashMap Tests: - Adds comprehensive cycle detection tests in all five runtimes to verify that cyclic partial references are handled correctly without infinite recursion, with each partial resolved exactly once. This ensures autoreload and dependency tracking work correctly across deep partial trees, with consistent behavior across all runtimes.
yesudeep
force-pushed
the
yesudeep/fix/complex-plants
branch
from
3a1356f to
6e1d9ca
Compare
This was referenced Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add cycle detection to partial resolution across all runtimes
The Rust implementation of resolve_partials only resolved one level of
partials, unlike Python, Java, Go, and JS which all recursively resolve
the entire partial tree. Additionally, none of the runtimes had explicit
cycle detection, which could cause infinite recursion when partials
reference each other (e.g., A -> B -> A).
This fix:
Rust:
Python, Go, JS, Java:
currently being processed:
Tests:
that cyclic partial references are handled correctly without infinite
recursion, with each partial resolved exactly once.
This ensures autoreload and dependency tracking work correctly across
deep partial trees, with consistent behavior across all runtimes.