-
Notifications
You must be signed in to change notification settings - Fork 434
Improve concurrency settings for PR checks
#3405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since `github.workflow` will be the caller's name for `workflow_call` events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the concurrency settings for PR check workflows by including workflow input parameters in the concurrency group name. This allows workflows with different input combinations to run in parallel while ensuring that workflows with the same inputs and ref are properly grouped for cancellation or queuing.
Changes:
- Modified the Python generator script to append all workflow inputs to the concurrency group name
- Updated the
cancel-in-progressexpression (added redundant|| falseclause) - Regenerated all 61 workflow files with the new concurrency group naming pattern
Reviewed changes
Copilot reviewed 56 out of 56 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pr-checks/sync.py | Updated concurrency group generation to include workflow input values; modified cancel-in-progress expression |
| .github/workflows/__*.yml (61 files) | Auto-generated workflow files reflecting the new concurrency group naming pattern with input values |
redsun82
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many thanks for this!
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist