Make create-release-pr aware of ABS setting .replace-app-version-with-git and update Chart.yaml accordingly
#89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GiantSwarm project that are not wrapping third party projects, we want the
.appVersioninChart.yamlfiles to match the application version, that matches the Chart version. For such projects we think of the 2 things as one and its misleading to not keep this updated in the repo as well. The Helm artifact will have it correctly, cos ABS updates at build time, but this GitHub workflow is responsible to commit it on the PR.Since this is totally separate from ABS, this is a best effort implementation to check if the project uses ABS and if the
.replace-app-version-with-gitsetting is enabled. If so, update that too in theChart.yamlfor the release PR.Tests: