Skip to content

Conversation

@uvegla
Copy link
Contributor

@uvegla uvegla commented Dec 16, 2025

In GiantSwarm project that are not wrapping third party projects, we want the .appVersion in Chart.yaml files to match the application version, that matches the Chart version. For such projects we think of the 2 things as one and its misleading to not keep this updated in the repo as well. The Helm artifact will have it correctly, cos ABS updates at build time, but this GitHub workflow is responsible to commit it on the PR.

Since this is totally separate from ABS, this is a best effort implementation to check if the project uses ABS and if the .replace-app-version-with-git setting is enabled. If so, update that too in the Chart.yaml for the release PR.

Tests:

@uvegla uvegla marked this pull request as ready for review December 16, 2025 15:48
@uvegla uvegla requested a review from a team as a code owner December 16, 2025 15:48
@uvegla uvegla merged commit 0836062 into main Dec 16, 2025
1 check passed
@uvegla uvegla deleted the make-create-release-pr-a-bit-abs-aware branch December 16, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants