feat(oauth): Add UI for creating and viewing public OAuth clients #106654
Conversation
- Add isPublic field to API application serializer - Update API endpoint to accept isPublic parameter when creating applications - Add client type selection modal when creating new applications - Show 'Public Client' or 'Confidential Client' tag on application details - Hide client secret section for public clients - Add info alert explaining public client behavior - Update frontend and backend tests
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Change Tag prop from 'type' to 'variant' (and 'default' to 'muted') - Change Alert prop from 'type' to 'variant' - Fix CreateApplicationModalProps to not extend full ModalRenderProps
…ecret on public clients - Replace custom ButtonBar styled component with existing ButtonBar from sentry/components - Add backend check to return 400 error when attempting to rotate secret for public clients - Add test to verify public clients cannot rotate secrets
- Move client type tag to subtitle in SettingsPageHeader for proper heading accessibility - Update acceptance test to handle new client type selection modal
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Address PR review comment - add isPublic: false to mock responses in 'renders basic details for confidential client' and 'handles client secret rotation' tests to match the ApiApplication type definition.
Summary
Adds frontend UI support for creating and viewing public OAuth clients, building on the backend support added in #106451.
Changes
Backend (
api_applications.py):isPublicparameter when creating new applicationsisPublic=True, create application withclient_secret=NoneSerializer:
is_publicfield toApiApplicationSerializeroutputFrontend UI:
Screenshots
Client type selection when creating new application
Public client details page showing no client secret
Test Plan
isPublicparameter handlingDepends on #106451 (merged)
Closes #99002